eslint-plugin-node

eslint-plugin-node copied to clipboard

ESLint v8.0.0 is released 🎉

It would be awesome to have official ESLint 8 support. 👊 I'm happy to help where I can of course 🙂

---

Follow-up of #223

Is anything broken in the current release and needs fixing for ESLint 8?

This module automatically supports ESLint 8: https://github.com/mysticatea/eslint-plugin-node/blob/f45c6149be7235c0f7422d1179c25726afeecd83/package.json#L12-L14

So unless something is broken, then this is a non-issue?

Is anything broken in the current release and needs fixing for ESLint 8?

Hi @voxpelli! I have one thing that is broken. The following file is currently not behaving correctly with Eslint version 8: https://github.com/adeira/universe/blob/8cff40fc01c2aca6ae01ec53cd8d1be07afd8c84/src/eslint-config-adeira/tests/fixtures/valid-eslint-examples/node/process-exit-as-throw.js

We created this file based on the official example because of some previous problems with this rule. Here is the error we are getting:

Thanks for having a look!

@mrtnzlml Great example! Can you add a dedicated issue for it, like a ESLint 8.x regression: node/process-exit-as-throw no longer works

for someone blocked by the plugin, I've just pushed a fork: eslint-plugin-n.

it just added supports for eslint v8.

@aladdin-add Can you summarize somewhere on how it relates to the ESLint 8 PR:s in this repo? What the changes are from upstream? + maybe links to PR:s for those changes?

Great to have a fork to use until upstream gets updated 👍

@aladdin-add Would be nice if we could transfer repos like eslint-plugin-node, eslint-plugin-es, eslint-utils & @mysticatea/eslint-plugin to a new @eslint-community org

CC/ @mysticatea

Thank you. I agree with @MichaelDeBoey. It would be nice to be able to take over maintenance and release from @mysticatea

As we need them for StandardJS as well, I think we can maybe add them there if we want a common org as well

Transferring them to the @standard org is fine for me too 🤷‍♂️ I just think we should transfer it to an org that will take care of maintenance long term, that's all

Just need to get in touch with @mysticatea somehow to get it done and then I think a lot of PRs can get merged quickly

nicholas also agreed to the eslint-community, will put together an RFC for how it will work.

Let me know if I can help somehow!

shy bump :sweat:

It seems like eslint-plugin-n is maintained version of this plugin.

eslint-plugin-n is the maintained version of this module.

We switched to it in eg. eslint-config-standard / standard and it is maintained by me and other members of the official ESLint community organization.