Steven Myint

Results 96 comments of Steven Myint

Looks good. I found one other edge case. Files like the following, get an empty `__all__` added to them. ```python def foo(): bar = 0 ``` ``` --- original/foo.py +++...

I guess the other thing I notice from the above is that this new feature affects all files. I think we should be conservative and only touch `__init__.py` files. This...

Yeah, the GCI task I specified is different to #249. The one I specified matches the test case @seeeturtle created. ```python def main(): global x print(x) main() ``` So I...

@seeeturtle One of the other PyCQA members needs to approve this before I can merge it. This is the case for several of the [open pull requests](https://github.com/PyCQA/pyflakes/pulls).

I'm not sure about PEP 8, but `pycodestyle` will complain about this. ``` test.py:2:15: E127 continuation line over-indented for visual indent ```

Thanks! My comments from https://github.com/myint/autoflake/pull/37 apply here as well.

Would this be possible given that cdiff only receives a diff and not a full file? For example, if the hunk contains Python code with `"""` in it, pygment's lexer...

I guess they switched [this](https://www.python.org/dev/peps/pep-0008/#should-a-line-break-before-or-after-a-binary-operator) at some point.

I think that should be `max_line_length` per `argparse`'s normalization.

Did you intend to write `lambda i, n` instead? If you really want a tuple `(i, n)`, then the reason it is converted to `i_n` is to support Python 3....