mybb2
mybb2 copied to clipboard
mybb
Feature: User Activity for #15
Do you also plan to add activities here (posting topic/post) or will you add it separately? Also you changed the getPresenter in the Post model but not in the others.
Yes, I plan to add support for core content types in this branch, but will open additional pull requests as other content types are created. And yes, I will change the other models. The only reason I fixed Post here is because I was editing the model anyway.
On 20 Mar 2015, at 14:43, Jones [email protected] wrote:
Do you also plan to add activities here (posting topic/post) or will you add it separately? Also you changed the getPresenter in the Post model but not in the others.
— Reply to this email directly or view it on GitHub.
Basic user activity for replies done. Other activities can be completed in the future as they're implemented. It will also need some nicer styling @justinsoltesz - it currently looks like this:
Totally unrelated but what is with those labels?
Pretty much everything is a new-feature/work-in-progress/feature-enhancement isn't it?
@Sama34 They'll be more useful in the future :) It's just good practise to get used to using them now rather than later.
Any more feedback on this or can we merge? The basics are done, but it needs styling @justinsoltesz.
@euantorano Is this still wip or can we start testing it? (After resolving conflicts)
Feel free to start testing :)
On 3 Apr 2015, at 12:32, Jones [email protected] wrote:
@euantorano Is this still wip or can we start testing it? (After resolving conflicts)
— Reply to this email directly or view it on GitHub.
@euantorano haha yeh I figured out that you just changed indentation, but someone should address these things ;)
Yep, this PR isn't the place to do so though really ;) It should be done in a separate PR.
We have a lot of things which don't follow our current t standards - all of them should be fixed in one go in a separate PR.
About injecting the config: feel free to do so, initially I planned to create an issue in the recaptcha library as I don't like setting config values like that.
I'll check this now. Do we want to show likes in the activity feed too? As that PR got merged now.
Also there are no changes to the database/* classes: no migration for the new table and the new setting(s) aren't added.
Odd. I'm sure I added that. I'll fix it tonight.
On 9 Apr 2015, at 18:13, Jones [email protected] wrote:
Also there are no changes to the database/* classes: no migration for the new table and the new setting(s) aren't added.
— Reply to this email directly or view it on GitHub.
@JN-Jones The migration is already there, might have been committed in the core earlier when I started working on this outside a PR. I'll add the settings though.
That explain why I haven't seen an SQL error though it told me that no migration was run. Will recheck later then.
Probably ;)
From: Jones Reply-To: mybb/mybb2 Date: Thursday, 9 April 2015 19:47 To: mybb/mybb2 Cc: Euan Torano Subject: Re: [mybb2] Feature: User Activity for #15 (#19)
That explain why I haven't seen an SQL error though it told me that no migration was run. Will recheck later then.
— Reply to this email directly or view it on GitHub.
One bug I've noticed: Starting a thread/topic shows as "Posted a reply" in the activity feed.
And some suggestions/things that can/should be added:
- The start topic (seed) isn't added and should be imho
- Sign Up could be saved as activity
- As we have profiles the activities should probably be shown there too
- A new page (user/Admin.1/activity) with the full activity feed for that user should be added