Results 18 comments of M vd S

> I know nothing about linker scripts, but replying to just your comment about `#undef` and `#ifdef` - maybe it'd make sense to use the same pattern used by e.g....

I fully agree @matsobdev, the potential for power efficient applications is huge. But it involves a lot of changes. Running from xosc at 12 MHz with pll_sys disabled for example,...

I have the setup working where the firmware is in its own section, that is shared between the two builds. With some modifications to the linker scripts, it works fine....

> I don't know. I am not against validating json in theory.. and you seem to have found a reasonable library. the schema is some standard format I assume? Yes,...

> In terms of the addon output we need to consider a potential performance impact compared to manual validation (which does not yet fully exist). It will surely be a...

> > I would like to keep the interface between addon and cppcheck as-is for now, and first finish what's on the table now. A few updates to this PR...

> heads up: #5870 will change the naming of the pytest-based test files > > I still haven't looked at this. I currently am in the midst of finished up...

> > I am confused why CI accepted this. > > hmm.. somehow it would be nice with a test for this.. I would assume a unit test can test...

> In the second `{}` it is a bit more questionable.. but as you say it's more likely that it's unintended bugs in cppcheck. I have the feeling that such...

> I'm uneasy about merging this without understanding what's going on - especially as it immediately diverges the linker script again from the pico-sdk one You're referring only to https://github.com/usedbytes/picowota/pull/16/commits/ab7cef858b92ec906a1b8ae4283fe22f133cc777...