mtasa-blue icon indicating copy to clipboard operation
mtasa-blue copied to clipboard

Bugfix: getVehicleCompatibleUpgrades returns different value on serverside and clientside

Open Inder00 opened this issue 3 years ago • 1 comments

  • getVehicleCompatibleUpgrades returns different value on serverside and clientside
  • The spoiler 1164 cannot be applied to any other vehicle than Uranus from server-side.

PoC:

cv Bullet
srun outputConsole(inspect(getVehicleCompatibleUpgrades(me.vehicle)))
crun outputConsole(inspect(getVehicleCompatibleUpgrades(me.vehicle)))
srun me.vehicle:addUpgrade( 1164 )

Fixes #2476

Inder00 avatar Dec 25 '21 09:12 Inder00

I've made a test resource to compare the difference in upgrades for all vehicles between client & server, and vice versa.

upgrades.zip

for all vehicles: /checkserverupgrades will print a list of upgrades which are available on the server, but not on the client /checkclientupgrades will print a list of upgrades which are available on the client, but not on the server

the lists are written as JSON to a file, server_output.txt or client_output.txt. (note: these files exists in your client resources folder, not server)

was this PR intended to completely resolve all differences, for all vehicles? because it seems there are still quite a few differences on both sides.

maybe my test resource overlooks something? check it out and let me know

Lpsd avatar Apr 09 '22 22:04 Lpsd

Lpsd's comment needs to be addressed.

patrikjuvonen avatar Jan 01 '23 14:01 patrikjuvonen

This draft pull request is stale because it has been open for at least 90 days with no activity. Please continue on your draft pull request or it will be closed in 30 days automatically.

github-actions[bot] avatar Apr 02 '23 01:04 github-actions[bot]

This draft pull request is stale because it has been open for at least 90 days with no activity. Please continue on your draft pull request or it will be closed in 30 days automatically.

github-actions[bot] avatar Jul 07 '23 01:07 github-actions[bot]

This draft pull request was closed because it has been marked stale for 30 days with no activity.

github-actions[bot] avatar Aug 07 '23 01:08 github-actions[bot]