qemu-user-static

qemu-user-static copied to clipboard

Is this a bug report, feature (enhancement) request or question? (leave only one on its own line)

/kind enhancement

Description:

I use GitLab CI runners on Kubernetes, and attach this as a service in the .gitlab-ci.yml.

This container doesn't appear to have a healthcheck, so kubernetes shows the pod as NotReady even when it's working just fine.

I don't really think we need much of a "real" healthcheck, but having one would at least make it clear to other systems that things are working fine, rather than ambiguous.

Describe the results you received:

Get NotReady on pod where this container is attached.

Describe the results you expected:

Get Running on pod where this container is attached.

@kevin-lindsay-1 Thanks for your feedback. https://docs.gitlab.com/runner/executors/docker.html#the-services-health-check As for this, I think it is not enough to add a dummy health check.

@lafin I have no preference for how the health check is implemented; every container typically has its own flavor.

I'm simply proposing to have a health check at all, because right now the container never enters a "healthy" state, which in kubernetes (and other systems) can introduce unintended behaviors if a container never becomes healthy.

I proposed a dummy health check only because a health check didn't look like it was considered very important previously, as this container doesn't currently have a health check at all.

@lafin do we not want to have a health check at all? I ask because I use this container in kubernetes, and without a health check kubernetes may treat the pod differently, because it never fully registers as "online".

If this is a won't-do, I can close the issue if you want.