puppeteer-headful

puppeteer-headful copied to clipboard

This will help with versions of chrome and nodejs.

Here is an example of what I think this syntax should look like. This allows the downloading of a specific version of node and chrome.

  - name: Test code
     uses: mujo-code/puppeteer-headful@v2
     with:
        node-version: '12.x'
        chrome-version: 'latest' 
     run: npm run test

@stefanbuck so the only way I can see this working would be the workaround mentioned in the feature request here.

https://github.community/t/feature-request-build-args-support-in-docker-container-actions/16846

Feel like this is going to take a little reworking of how this action works and seems like it would slow down build times since we would be building a docker container in a docker container. I can play around with it this weekend and see how well this works.

Actually thinking about this, we can probably just tag the new versions. I think that is what I actually did in the past to make it align with the version of NodeJS in the container.

Actually might want to do this request with only Chrome versions and then we can tell people if they want a Nodejs version they need to find the nearest tag.

Actually might want to do this request with only Chrome versions and then we can tell people if they want a Nodejs version they need to find the nearest tag.

Mhhh, so a new version of this Action whenever a new Chrome version comes out, is this what you are saying? Does this scale / work in the long run? Another option is to use node:latest but this could break anytime. I'm not really sure what’s best here to be honest.

Yeah, a new tag for each NodeJS version. We run into a similar issue trying to add params to the Chrome version even though I could see some benefits to being able to test on beta or canary.