mui-x icon indicating copy to clipboard operation
mui-x copied to clipboard

[docs] Add Recipes section

Open cherniavskii opened this issue 3 years ago • 1 comments

Adding the first recipe to kick off the discussion around this topic. It was extracted from issues https://github.com/mui/mui-x/issues/2851 and https://github.com/mui/mui-x/issues/5007

Preview: https://deploy-preview-5744--material-ui-x.netlify.app/x/react-data-grid/recipes/

cherniavskii avatar Aug 09 '22 18:08 cherniavskii

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 317.6 578.8 482.2 445.54 98.875
Sort 100k rows ms 467.4 888.8 808.2 738.74 148.985
Select 100k rows ms 200.1 294.1 226.2 236.4 32.901
Deselect 100k rows ms 128.6 261.1 194.3 188.86 44.227

Generated by :no_entry_sign: dangerJS against d6ccf812f3ad029e61cd34166376f8e944c8245c

mui-bot avatar Aug 09 '22 18:08 mui-bot

I've moved examples from Editing "Advanced use cases" section to Recipes page. I've also added one more recipe for Row grouping: https://deploy-preview-5744--material-ui-x.netlify.app/x/react-data-grid/recipes/#toggling-groups-on-row-click

cherniavskii avatar Aug 31 '22 12:08 cherniavskii

Sorry if the question has already been asked But wouldn't it be better to already split the page in two (one for editing and one for row grouping) ? To avoid a routing breaking change in a few months when this page will be too long

flaviendelangle avatar Sep 01 '22 07:09 flaviendelangle

Sorry if the question has already been asked But wouldn't it be better to already split the page in two (one for editing and one for row grouping) ? To avoid a routing breaking change in a few months when this page will be too long

I was wondering about this in https://github.com/mui/mui-x/pull/5744#discussion_r941655603 I agree that avoiding breaking URLs is a solid argument to split right now 👍

cherniavskii avatar Sep 01 '22 09:09 cherniavskii

@DanailH

The only feedback I have is that the code previews are not showing - it's probably an issue with the renaming of the file. Regenerating them should do the trick of fixing it.

I turned previews off intentionally, because in case of Recipes preview is too short to be useful. In the preview you'll only see the return data grid component and some props, while usually the important part is somewhere else - so you'll have to see the whole code anyway.

cherniavskii avatar Sep 22 '22 08:09 cherniavskii

Has anyone solve the issue no: #5381 ?

ghost avatar Oct 17 '23 07:10 ghost