Michael J. Sullivan comments

Results 290 comments of


                                            Michael J. Sullivan

Overloading one_of constraint throws strange error

Yeah, this is a reduced case that exhibits the bug

Cannot silence "unused 'type: ignore'" in version specific code

I think we need a way to silence unused type ignore messages for individual type ignores short of disabling the warning.

abs(Union[int, Decimal]) is inferred as object

Yeah, I agree that would probably be a better type in this case. But whether to infer a union type or a join is tricky and changing behavior will break...

Process schema files in a deterministic order

Prompted by https://github.com/edgedb/edgedb/issues/6161, which I couldn't reproduce directly from the provided schema directory because of this nondeterminism

ERROR InternalServerError: [Errno 24] Too many open files

Hm, are you making lots of separate connections (like one connection per query)? Can you provide server logs? It looks like we do try to increase the limit on number...

ERROR InternalServerError: [Errno 24] Too many open files

I mean logs from the edgedb server when the error occured

ERROR InternalServerError: [Errno 24] Too many open files

These are all client side logs; do you have any logs from the server itself? If this is a local instance you can probably extract them with `edgedb instance logs`

ERROR InternalServerError: [Errno 24] Too many open files

Yeah, you should just have one client, probably. You'll be establishing way more connections than you need to otherwise. The client does connection pooling internally too, I think, so you...

ERROR InternalServerError: [Errno 24] Too many open files

Could you provide more logs from that last one?

ERROR InternalServerError: [Errno 24] Too many open files

Yes, one client is the recommended workflow