node-ftp icon indicating copy to clipboard operation
node-ftp copied to clipboard

Published 20 hours ago • verified publisher icon mscdex

Change to emit `end` and `close` immediately at EOF during download

Open std4lqi opened this issue 5 years ago • 3 comments

Signed-off-by: Qi Liang [email protected]

Change to emit end and close at EOF immediately during download, without waiting for 226 or 250 for RETR. This could close the stream quickly, instead of hanging for 1 or 2 minutes on Node.JS v10 and v12.

std4lqi avatar Dec 17 '19 02:12 std4lqi

It's to fix #228 actually.

std4lqi avatar Dec 17 '19 02:12 std4lqi

I have also run into a similar issue on Node 11 and 12, and can confirm this PR fixes it. Thanks @std4lqi!

thingalon avatar Jan 09 '20 03:01 thingalon

See https://github.com/mscdex/node-ftp/issues/277

jasonwilliams avatar Nov 25 '21 11:11 jasonwilliams