isla w

Results 35 comments of isla w

@swissspidy (not sure if this link will maintain) but do you happen to know why sometimes it says a line isn't covered by tests when it clearly is. Simple example...

I believe all of the original issues here have been addressed and code coverage works as expected in most cases now. @swissspidy if you agree I think we can mark...

If this is just a temporary issue until we change the PHP requirement after the next release happening soon, could we also just not run the coverage tests for the...

If the only thing this is waiting on is a test, I believe this would cover everything mentioned above: ```cucumber Feature: Bootstrap WP-CLI Scenario: Test early root detection Given an...

As original author I got pinged in https://github.com/go-gitea/gitea/pull/10814#issuecomment-2526553126 for opinion. The claims of: > there was no intention to "group" or divide labels by org defined and repo defined. >...

I notice that we use `--force` in most other commands for similar behavior. Would it be better to name this `--force` and not `--force-check` to match existing commands?

Tempting to just remove the flag and make this the default behavior if we're also having the discussion of a 3.0 release that can include 'breaking' changes https://github.com/wp-cli/wp-cli/issues/6026 I know...

> Having both force-check and skip-update-check is certainly confusing 🤔 I agree it feels weird to have both a `--force-check` and `--skip-update-check` (I don't really understand the benefit of `--skip-update-check`...

Could probably just put a `delete_site_transient( $this->upgrade_transient );` inside here above the `call_user_func` https://github.com/wp-cli/extension-command/blob/33afe4f86812a3173c20a584c6a070e68dfafc4c/src/WP_CLI/CommandWithUpgrade.php#L544-L547 Interesting that comment suggests to me that this should already be happening