Justin Crown

Results 21 comments of Justin Crown

https://github.com/modlinltd/django-advanced-filters/pull/82

@asfaltboy do you know if there are any inflight branches for this, or should we go ahead and start from scratch?

@betsy thanks for filing the issue! Your suggestion sounds reasonable, would be happy to review a PR!

Hey @SaigeGithub ! It looks like it is more than just the page ID missing that is problematic, the code currently assumes that `pages` is a top level key, and...

In general, people will want to be able to pip install either version. As such, would it make sense to add an `extras` keyword to setup.py for the scoped keys...

Ah, I see what you are saying, makes sense. I don't think that pip has any native features allowing for dependency exclusion, let me look into some alternatives.

Sounds good @BlackVegetable let me know if you need any help, thanks!

Hello! This seems to be similar to the issue outlined in this pull request: https://github.com/ilogue/fexpect/pull/19 I have encountered the same error. From my understanding, pexpect should not need to be...