Zbyněk Novotný
Zbyněk Novotný
Well, you wanted to salvage my changes from the old branch, so I thought it shouldn't hurt to just to take them and put them in a new branch. 😄...
Cheers for the feedback, @RaynaldM . I have integrated it along with a modification to the `FileConfigurationFluentValidator` to allow for multiple routes having the same upstream path but different routing...
Having taken a look at how URL placeholder extraction and replacement works, it's quite obvious that the current algorithm (implemented in `UrlPathPlaceholderNameAndValueFinder`) has been designed to work with URL's (routes...
> @raman-m requested changes [on Aug 14](#pullrequestreview-1577258486) I work in Linux. There is no Visual Studio for that. I have already had to disable `.editorconfig` because apparently Rider cares about...
Integrated your PR feedback, @raman-m . See https://github.com/ThreeMammals/Ocelot/pull/1684/commits/6d29040db6570a01847ef596a2cdc583e146ad6c and let me know what you think. I tried to cover all of it so here's hoping I have succeeded at that....
Ping @raman-m, hope you didn't fall off the edge of the earth. :slightly_smiling_face:
> @raman-m commented [on Sep 15](#issuecomment-1721466290) I have disabled the line ending settings inside .editorconfig so Rider won't enforce them. I don't think I can do much more than that,...
> > @raman-m requested changes [on Aug 14](#pullrequestreview-1577258486) > > @mrclayman I've resolved all issues of the [1st code review](#pullrequestreview-1577258486). The [2nd code review](#pullrequestreview-1626799024) is ongoing... > > Consider renaming...
> @mrclayman Conflicts in usings block mostly! Use Remove and Sort Usings refactoring operation of Visual Studio. So, usings must be sorted! And pay attention, we have global usings now...
All right, I have rebased this branch against the current state of `develop`. Tried my best with regard to the line endings.