Tom Mrazauskas
Tom Mrazauskas
> We could possibly move our `ImportMeta` declaration? @SimenB What did you had in mind here? Just to remove it? I just checked if `@types/jest` has definition for `unstable_mockModule`, but...
Wait. I just checked again and it looks like after `requireActual` and `requireMock` got improved on Jest side there is just one change missing `@types/jest` to make it all work....
The missing part is here: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/62259
All fixes of `@types/jest` are merged and shipped with v29.0.3. Try it out. As mentioned before the culprit now are Jest’s build-in types of `requireActual` and `requireMock`. These got fixed...
I was playing with my reproduction. Error is gone with `jest` v29.1.0 and `@types/jest` v29.0.3. Would be nice is someone could double check.
> Made some changes but have no access to push. Did you try opening a [Pull Request](https://github.com/facebook/jest/blob/main/CONTRIBUTING.md#workflow-and-pull-requests)?
Thanks! Could you split the PR, please? That is rather large change and it is hard to review everything in one go. It would be perfect to keep one file...
Right, but I would like to be able to look through the whole source of each file. Just to make sure that there will be no need to come back...
Perfect! Thank you so much. This is very helpful. I have left reviews in all the PR. Here is a couple of more general notes: - it would be perfect...
Thanks a lot for the effort. Just left comments with more details in each PR. Yesterday I was in hurry to look through everything. Hope now all is clarified. Yes,...