Matthew Pickering

Results 200 comments of Matthew Pickering

It's not clear to me we should be getting involved in this. Needs more motivation I think before attempting to fix something.

I don't really understand the API changes in this PR. Do I understand right the goal is to expose the selected `CradleConfig`?

I'm not sure what is better but would this API work? * `findCradle :: FilePath -> IO (Maybe FilePath, Origin CradleConfig)` * Add a cradle root dir field to `CradleConfig`...

Or perhaps ``` data Origin a = Explicit FilePath a | Implicit a ```

I'm also not sure that `loadCradle` needs to be in `IO`. I suspect not. The difference between `CradleConfig` and `Cradle` is meant to be that `CradleConfig` closely corresponds to what...

> > Or perhaps > > ``` > > data Origin a = Explicit FilePath a | Implicit a > > ``` > > does that mean `findCradle` would be...

@madgen It would be good if you could implement this interface. Either here or a separate PR is fine.

I was looking into this ticket again today and it seems a bit awkward to implement. You really want to distinguish between the case where there's a `hie.yaml` file or...

@ethercrow I can try on GHC if you tell me how to emit the right traces. If it doesn't involve a library that would be better or I should be...

I instrumented GHC and it seems there is something broken in the zipkin exporter because each event seems to end up in its own trace. Also problems with * Eventlog...