Mike Perham

Results 320 comments of Mike Perham

I don't recall any reason why your idea wouldn't work. A PR would be awesome, please include a benchmark for 1000 processes before/after so we can verify the performance improvement...

> I'm using it to prevent jobs duplication to be run This is not a good idea. Work is only updated every N seconds so you'll get dupes anyways.

It's part of the heartbeat: https://github.com/mperham/sidekiq/blob/a2708ea849aabdb7f62129a07ba752225c621e89/lib/sidekiq/launcher.rb#L150-L158

I think that's a worthwhile change. The memory increase is painful but I don't see any obvious improvements without a larger, possibly painful, refactoring.

Right, I can't guarantee every Sidekiq feature will work with ActiveJob as I don't control ActiveJob. That said, your build_client suggestion is a good one but it's not technically a...

I envision the page only fetching the latest minute value and updating the graph/table. I don't think it would be good to refresh the entire page/content.

Main. 6.x is closed except for important bug fixes.

Lots of Sidekiq users use Elasticache Redis instances, just make sure you configure the instance memory policy correctly according to the Using Redis wiki page. I have no experience or...

My code copies the standard `assert_equal expected, actual` ordering.