Mike Perham
Mike Perham
I've tried to do this before, it was tricky to determine whether it is safe or not. Additionally I realized it could be better to retain backwards compatibility with racy...
It's possible the problem is using a Symbol instead of a String. Sidekiq stringifies everything but I don't know that ActiveJob does. Try `"unique_for" => false` instead.
I can't explain what's wrong. You'll need to step thru it with a debugger.
Been a long time, Matt, hello from Railsconf! Send a PR?
@sobrinho Conventions >>> Configuration. Sidekiq's convention is that all job data is native JSON, period. That also means you can use Redis's JSON functionality with Sidekiq. https://redis.io/docs/data-types/json/ If we allow...
Ah, fair enough. Yes, it seems weird to treat the args element separately from the rest of the payload but I see your point. I'm still unlikely to accept this...
It would be almost trivial to create a SerializedArguments module prepended to Sidekiq::Job which stores the marshaller as a job payload element and runs the job arguments through the marshaller...
Not the right direction.
This is a totally new feature to me and not something I've used before so please give me some time to study the code, understand what it is doing and...
Great work. I'll merge this and spend a little more time polishing it soon.