Mridula
Mridula
The `generation diff / root-pom` check failure is expected as this sample module hasn't been included in https://github.com/googleapis/sdk-platform-java/blob/main/library_generation/templates/root-pom.xml.j2 yet (thanks for the context @JoeWang1127)
The presubmit is detecting changes in the sample: [Edit] This is expected behavior.
Thank you! Confirmed by running the stage job with this PR's commit that we aren't staging any of the sample artifacts.
Thanks for following up. IIUC, this is a feature request and not a regression in existing support. As described in the [CONTRIBUTING.md doc](https://github.com/GoogleContainerTools/jib/blob/master/CONTRIBUTING.md) we are currently prioritizing critical bug fixes...
@bjornbugge Thanks so much for this fix! It appears that the test jobs are failing with the following error: ``` Task :jib-core:checkstyleTest FAILED Build cache key for task ':jib-core:checkstyleTest' is...
Logging stacktrace: ``` com.google.cloud.tools.jib.image.ReproducibleLayerBuilderTest > testBuild_timestampDefault FAILED expected: 1970-01-01T00:00:01Z but was : 1970-01-01T00:00:00Z at com.google.cloud.tools.jib.image.ReproducibleLayerBuilderTest.testBuild_timestampDefault(ReproducibleLayerBuilderTest.java:301) com.google.cloud.tools.jib.image.ReproducibleLayerBuilderTest > testBuild_parentDirBehavior FAILED expected: 1970-01-01T00:00:01Z but was : 1970-01-01T00:00:00Z at com.google.cloud.tools.jib.image.ReproducibleLayerBuilderTest.testBuild_parentDirBehavior(ReproducibleLayerBuilderTest.java:239) com.google.cloud.tools.jib.image.ReproducibleLayerBuilderTest > testBuild_timestampNonDefault...
Thanks for the observation @diegomarquezp! @bjornbugge try running `./gradlew googleJavaFormat` to address the google formatting issues. Additionally, to @chanseokoh's suggestion in https://github.com/GoogleContainerTools/jib/pull/4142#discussion_r1469684533, we haven't heard back from you on this...
Closing in favor of #4204. Thanks for getting us started with this fix!
@ReillyBrogan This seems like a valuable use case! One quick note, we think this should start off as being "opt-in" at least to begin with. We can consider making this...
@golosegor Quick update: jib-gradle-plugin:3.4.2 has been release with a [fix](https://github.com/GoogleContainerTools/jib/pull/4204). Please let us know if this addresses your issue?