multi-account-containers icon indicating copy to clipboard operation
multi-account-containers copied to clipboard

Show error message and troubleshooting steps on contextual identities error

Open brizental opened this issue 1 year ago • 1 comments

Before submitting your pull request

  • [x] I agree to license my code under the MPL 2.0 license.
  • [x] I rebased my work on top of the main branch.
  • [x] I ran npm test and all tests passed.
  • [ ] I added test coverages if relevant.

Description

This is just a suggestion. See screenshot of what the error looks like:

Screenshot 2023-11-17 at 18 56 41

Two things:

  1. That is not a content suggestion. I couldn't come up with something good so I just added a sentiment there for now 🆘
  2. I had no idea how to add new strings. I added something directly in the l10n submodule. Here it is, just for illustration purposes: https://github.com/brizental/multi-account-containers-l10n/pull/1/files

Type of change

  • [x] Bug fix
  • [ ] New feature
  • [ ] Major change (fix or feature that would cause existing functionality to work differently than in the current version)

Tag issues related to this pull request:

  • https://github.com/mozilla/multi-account-containers/issues/2597

brizental avatar Nov 17 '23 18:11 brizental

I had no idea how to add new strings. I added something directly in the l10n submodule. Here it is, just for illustration purposes: https://github.com/brizental/multi-account-containers-l10n/pull/1/files

You can open a PR on the upstream l10n repository and simply mention that it depends on this PR to be merged.

That is not a content suggestion. I couldn't come up with something good so I just added a sentiment there for now 🆘

Looks good to me.

dannycolin avatar Nov 29 '23 01:11 dannycolin