bugbug icon indicating copy to clipboard operation
bugbug copied to clipboard

[code review] Review Helper is complaining about removed code

Open hotsphink opened this issue 4 months ago • 1 comments

I feel like this used to work, but recently the helper has been giving me review comments about code that is being removed by the patch. It's hard to find an example since the suggestions are gone now in the patches that I have now reviewed, but a simple example is something like "function foo() should no longer be called because [complex explanation about why the patch has changed things]", where the call to foo() is being removed in the patch.

I tried looking for an example. I will update this issue when it next happens.

hotsphink avatar Dec 10 '25 17:12 hotsphink

Thank you for reporting this. If you share a Phab revision, I could look it up from the backend.

suhaibmujahid avatar Dec 10 '25 17:12 suhaibmujahid