bugbug icon indicating copy to clipboard operation
bugbug copied to clipboard

[code_review] Add example of unwanted "Ensure ..." comments to the filtering phase

Open marco-c opened this issue 1 year ago • 2 comments

We have noticed this type of comment is either ignored or marked as invalid by users. We should filter it out.

marco-c avatar Aug 20 '24 15:08 marco-c

Examples:

  • The test setup correctly sets the hasUserNamespaces property to false and resets it after the test. Ensure that the test accounts for both dark and light themes when checking for the expected background color.
  • The new conditional check for aFlags before calling InitResizeFlags introduces a new behavior where resize flags may not be initialized in some cases. Ensure that all code paths setting aFlags are reviewed to confirm that this behavior is intentional and correctly implemented.

suhaibmujahid avatar Aug 20 '24 19:08 suhaibmujahid

This should be covered by #4579. We should test after that one is fixed.

marco-c avatar Nov 14 '24 23:11 marco-c