firefox-ios

firefox-ios copied to clipboard

When I open the homepage for the first time, I see a message about toolbar location, which makes me aware that I can change from bottom to top based on my preference

Acceptance Criteria

• A toolbar position pop up message will be displayed the first time a new user opens the homepage
• There is a settings link that goes to the toolbar position settings
• If the user clicks on the X to close the message or clicks elsewhere on the homepage, then the message will close
• The pop up message matches the attached designs
• The message is behind the MR Onboarding Nimbus feature flag
• The following telemetry is captured:
  • Impression counts
  • Click counts on the settings link
  • Click counts on the X
  • Clicks elsewhere on the screen that close the message are counted

┆Issue is synchronized with this Jira Task

➤ Nishant Patel commented:

Some questions to understand the details:

Most of this work has already been done. What exactly are you looking to update about the toolbar CFR for this ticket?

When you say, The message is behind the MR Onboarding Nimbus feature flag , you mean the popup appearing at all right?

Regarding impression counts telemetry - do we plan on presenting these CFRs multiple times now? Currently, we’re setup so that if a CFR has been presented, we don’t show it again.

In the Figma, I see a CFR for the bottom toolbar. But I guess based on this https://mozilla-hub.atlassian.net/browse/FXIOS-4628 ( https://mozilla-hub.atlassian.net/browse/FXIOS-4628|smart-link ) , we need the designs specifically for the top location. Are we updating the message copy for the top toolbar popup?

➤ Nishant Patel commented:

For this ticket, there’s some things to note:

• The toolbar position is NOT set to top by default in here. However, I’ve set it to top by default in beta and dev. So testing would require looking in Beta, which I guess means the v9000 nightlys.
• We’ve put up a feature flag, but not for MR Onboarding. What an MR means and what it contains changes every six months. So instead, we made toolbar CFR specifically toggleable. Each CFR will be individually toggable via Nimbus.

➤ Simion Basca commented:

We’ve tested this issue in v9000 (15189). In order to mark this issue as verified fix the following issues should be addressed.

• https://github.com/mozilla-mobile/firefox-ios/issues/11526 ( https://github.com/mozilla-mobile/firefox-ios/issues/11526|smart-link )

• https://github.com/mozilla-mobile/firefox-ios/issues/11533 ( https://github.com/mozilla-mobile/firefox-ios/issues/11533|smart-link )

➤ Simion Basca commented:

Marking as fixed on v104.1(#16952) and 105.0 (16884).

• A toolbar position pop up message will be displayed the first time a new user opens the homepage ✅
• There is a settings link that goes to the toolbar position settings ✅
• If the user clicks on the X to close the message or clicks elsewhere on the homepage, then the message will close ✅
• The pop up message matches the attached designs ( https://www.figma.com/file/7J6gh5D8DbGTExxskKdn3T/Mobile-Onboarding?node-id=1950%3A64023 ) ✅
• The message is behind the MR Onboarding Nimbus feature flag ✅

Note that for the telemetry we were unable to test it in Glean as it was not displayed → https://mozilla-hub.atlassian.net/browse/FXIOS-4717 ( https://mozilla-hub.atlassian.net/browse/FXIOS-4717|smart-link ) .

However the telemetry seems to be recorded OK in the looker app → https://mozilla.cloud.looker.com/explore/firefox_ios/event_counts?toggle=fil,vis&qid=YYta5orGNKQ5PM8f5xslXZ ( https://mozilla.cloud.looker.com/explore/firefox_ios/event_counts?toggle=fil,vis&qid=YYta5orGNKQ5PM8f5xslXZ )

➤ Andrei Bodea commented:

Verified as fixed on v106 (19379) with iPhone 13 Pro (15.1.1).

• A toolbar position pop-up message will be displayed the first time a new user opens the homepage ✅
• There is a settings link that goes to the toolbar position settings ✅
• If the user clicks on the X to close the message or clicks elsewhere on the homepage, then the message will close ✅
• The pop-up message matches the attached designs ( https://www.figma.com/file/7J6gh5D8DbGTExxskKdn3T/Mobile-Onboarding?node-id=1950%3A64023 ) ✅
• The message is behind the MR Onboarding Nimbus feature flag ✅