lockwise-addon icon indicating copy to clipboard operation
lockwise-addon copied to clipboard

Create new account in Lockwise addon triggers the Fx save dialog

Open sandysage opened this issue 6 years ago • 3 comments

When testing the extension, I created a new account (new login -> create login). Upon hitting create login, Firefox asked to save for the non-human readable moz extension: Screen Shot 2019-05-10 at 9 09 18 AM

We saw this as a blocker for users in past research (every participant was unable to complete their task because of the added request). How can we address this without asking someone to turn off all "save logins and passwords"? Screen Shot 2019-05-10 at 9 13 22 AM

sandysage avatar May 10 '19 15:05 sandysage

Logic is in place to disable saving on the extension URL, and locally I can see this working as expected. However, the logic doesn't take full effect unless signons.rememberSignons ("Ask to save logins and passwords for websites") is enabled before the extension loads, and the extension does not make multiple attempts to set its URL as disabled.

Some questions:

  • The steps were performed via npm run run?
  • Was "Ask to save logins and passwords for websites" enabled immediately after running npm run run?
  • If you go to "Manage addons" (about:addons) and disable then enable the extension, does it still prompt to save the login?

It was a debate when this logic was first added if multiple attempts should be made, and decided at the time not to. We can revisit that decision and change it fairly easily.

linuxwolf avatar May 10 '19 16:05 linuxwolf

I reproduce this via npm run run too when editing an existing entry:

Was "Ask to save logins and passwords for websites" enabled immediately?

No 👎

If you go to "Manage addons" (about:addons) and disable then enable the extension, does it still prompt to save the login?

No 👎

devinreams avatar May 10 '19 18:05 devinreams

If you go to "Manage addons" (about:addons) and disable then enable the extension, does it still prompt to save the login?

I should have prepended 'After enabling "Ask to save logins and passwords for websites" ...'

This workaround resolves it for me ...

  1. Go into about:preferences#privacy and make sure "Ask to save logins ..." is checked
  2. Go to about:addons and
    1. disable this extension
    2. enable this extension

linuxwolf avatar May 10 '19 18:05 linuxwolf