lockbox-extension
lockbox-extension copied to clipboard
Extract the runner for extensions out of webext
Instead relying on all JPM does and having yet-another-environment (tox vs temporary load add-on).
Per discussion with @rpl at All Hands.
@devinreams I've just pushed in the following branch a small prototype of a nodejs script that can be used as a base to replace jpm to run the build extension:
https://github.com/mozilla-lockbox/lockbox-extension/compare/master...rpl:npm-run-without-jpm?expand=1
Then I created a .npmrc file (which seems to be how personal developer options are included in the current run script based on jpm)
run_firefox_bin_path = /home/rpl/Applications/firefox-nightly/firefox
and then, by executing npm run run-firefox, a temp profile is being created, the custom options are set in the temporarily created profile, the dist directory copied into the temp profile, and finally Nightly is started using that profile.
Let me know how the approach looks to you (and how it goes once you had the chance to give it a try, I briefly tried it locally and I've got the Lockbox tab loaded in the Nightly instance started on the temp profile, but you are more likely to spot any issues related to differences with the previous development workflow or with the expected Lockbox extension behavior, that I'm likely to miss).
Thanks again for your help and quick work @rpl! We really appreciate it.
@jimporter @linuxwolf which of you two would be best to look into taking it from here and helping the team determine priority, review the changes, etc.
@devinreams we'll get it sorted out in our sprint planning.