lockbox-datastore icon indicating copy to clipboard operation
lockbox-datastore copied to clipboard

Define relevancy APIs for exposing data

Open linuxwolf opened this issue 8 years ago • 9 comments

The purpose of this API is to allow a content script to check if the datastore might have credentials for the current web page.

The API should take the URL, and return back some sort of indication there is (or is not) at least one relevant item. The implementation should not require the datastore to be unlocked in order to return positive results.

linuxwolf avatar Aug 31 '17 17:08 linuxwolf

@linuxwolf @jimporter given we first need lock/unlock #6 how confident do you feel about building search as part of Alpha?

devinreams avatar Sep 08 '17 18:09 devinreams

It'd be pretty easy to make a super-simple search interface for alpha.

jimporter avatar Sep 11 '17 22:09 jimporter

It should be fairly easy to do a basic "substring" search over title and username, all in the "./manage" view.

linuxwolf avatar Sep 11 '17 22:09 linuxwolf

for possible inspiration, or a base: https://github.com/enkidevs/react-search-input

linuxwolf avatar Sep 11 '17 22:09 linuxwolf

Added a front-end issue for search interface: https://github.com/mozilla-lockbox/lockbox-extension/issues/80

Talked with @linuxwolf and this items purpose should be more around a 'search the page and send back relevant data' API, for lack of better words right now.

devinreams avatar Sep 15 '17 19:09 devinreams

As an initial implementation, I was planning on doing all this in the front-end. It would probably be best to put it in the backend eventually, but that adds some complexity to the data synchronization that I don't want to get into for alpha.

jimporter avatar Sep 15 '17 19:09 jimporter

Updated the description to limit its scope.

This functionality something that can only really be done in the back-end.

linuxwolf avatar Sep 15 '17 19:09 linuxwolf

Oh, right. That's a bit different than the question Devin was asking me. Still, it might make sense to have search in the backend too. We can discuss that elsewhere, though.

jimporter avatar Sep 15 '17 19:09 jimporter

Given where we're initially going with autofill mozilla-lockbox/lockbox-extension#467, moving this back to the inbox for now.

sandysage avatar Jan 22 '18 18:01 sandysage