react-lazylog icon indicating copy to clipboard operation
react-lazylog copied to clipboard
verified publisher icon mozilla-frontend-infra

onRowClick never gets triggered

Open benjaminRomano opened this issue 7 years ago • 1 comments

I'm working on typescript defintions for react-lazylog and noticed any inconsistency.

Line has an onRowClick property, which gets passed into LineContent's onClick prop. However, LineContent does not have an onClick prop and therefore cannot be triggered.

https://github.com/mozilla-frontend-infra/react-lazylog/blob/master/src/components/Line/index.jsx#L76

https://github.com/mozilla-frontend-infra/react-lazylog/blob/master/src/components/LineContent/index.jsx#L13

benjaminRomano avatar Jun 09 '18 09:06 benjaminRomano

Here is the typescript definitions PR fyi: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/26402

benjaminRomano avatar Jun 09 '18 10:06 benjaminRomano