react-autowhatever icon indicating copy to clipboard operation
react-autowhatever copied to clipboard

Published 20 hours ago • verified publisher icon moroshko

Don't default isOpen to false if using renderItemsContainer with empty items

Open caguthrie opened this issue 7 years ago • 1 comments

This PR addresses this Github issue in react-autosuggest: https://github.com/moroshko/react-autosuggest/issues/486

If a renderItemsContainer is provided, isOpen is true. We may want the items container to be open even if there are no renderedItems.

I literally used the code change that @moroshko suggested, and added the requisite tests.

caguthrie avatar Mar 23 '18 15:03 caguthrie

Also, if this is merged, can a version please be cut so I can raise a PR into react-autosuggest. In addition to the version bump in the package.json and the code snippet in the above issue I will put in react-autosuggest, some tests in react-autosuggest will need to be changed as they expect the items container to be closed when there are no suggestions,

caguthrie avatar Mar 23 '18 18:03 caguthrie