Morgante Pell

Results 212 comments of Morgante Pell

The fix here would be to add the network tags (from the first pool) in the cluster config, like we do for [service account](https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/autogen/main/cluster.tf.tmpl#L289). Happy to review a PR.

Yeah we should change the `var.region` call there to a `local.region` which pulls the region from zone if region is null.

Unfortunately Terraform Core doesn't support optional object values - https://github.com/hashicorp/terraform/issues/19898

@bharathkkb We might want to consider changing the variable to `folder_ids`. Even though `name` is the technical definition, it's definitely confusing given the presence of `display_name` as well. Changing this...

Agreed, but I think it's overall low-priority.

Example: https://github.com/GoogleCloudPlatform/professional-services/tree/main/examples/terraform-ilb

No progress as it's still on our backlog, but we'd be happy to review a PR.

@Harjot1Singh Thanks, those look to be along the lines of what we'd need but note the updates need to be made in `autogen/` first.

Currently we expose serverless NEGS as both HTTP and HTTPS. This is meant to provide an opinionated design choice and not introduce unnecessary complexity to the module interface. If you...