Xpedite icon indicating copy to clipboard operation
Xpedite copied to clipboard

Mark the stack as noexec in asm files

Open octurion opened this issue 1 year ago • 3 comments

A missing .note.GNU-stack section implicitly marks the stack as PROT_EXEC:

warning: ProbeCtl.o: missing .note.GNU-stack section implies executable stack
NOTE: This behaviour is deprecated and will be removed in a future version of the linker

AFAICT, Xpedite doesn't rely on an executable stack, so we can explicitly mark it as noexec.

octurion avatar Jul 02 '24 10:07 octurion

@octurion Thank you for spotting the issue and we are glad to receive the PR. Since this is the first time you are contributing, we need the PR to include a DCO document. Can you please take a look at the instructions here?

Please let me know if you need any details / clarification.

Regards Mani

Mani-D avatar Jul 02 '24 19:07 Mani-D

Please let me know if you need any details / clarification.

Just a quick question: Given that the DCO document is going to be public, is it okay if I e.g. obfuscate my email address in my DCO so that it can't be easily scraped?

octurion avatar Jul 03 '24 22:07 octurion

Please let me know if you need any details / clarification.

Just a quick question: Given that the DCO document is going to be public, is it okay if I e.g. obfuscate my email address in my DCO so that it can't be easily scraped?

yes, of course.

Mani-D avatar Jul 03 '24 23:07 Mani-D

DCO added :+1:

octurion avatar Jul 04 '24 04:07 octurion

DCO added 👍

Excellent. Thank you !

Mani-D avatar Jul 04 '24 04:07 Mani-D