moodle-plugin-ci icon indicating copy to clipboard operation
moodle-plugin-ci copied to clipboard

Published 20 hours ago • verified publisher icon moodlehq

Phpcs and phpdoc report errors in thirdpartylibs in a subplugin

Open marinaglancy opened this issue 1 year ago • 1 comments

Here is the plugin https://github.com/marinaglancy/moodle-tool_realtime it has subplugins, one of them (plugin/pusher) has thirdpartylibs.xml that lists a bunch of 3rd party libraries.

This command reports no errors:

moodle-plugin-ci phpcs admin/tool/realtime/plugin/pusher/

However this command reports a bunch of errors in the paths that should be excluded by thirdpartylibs.xml in the pusher plugin:

moodle-plugin-ci phpcs admin/tool/realtime

On top of that, running moodle-plugin-ci from the GHA for the tool_realtime plugin also reports the errors in the paths that should be excluded, see https://github.com/marinaglancy/moodle-tool_realtime/actions/runs/10165832133/job/28114587219 for example

What should I do in this case?

marinaglancy avatar Jul 30 '24 16:07 marinaglancy