monodevelop icon indicating copy to clipboard operation
monodevelop copied to clipboard

Preview tabs

Open netonjm opened this issue 7 years ago • 7 comments

Adds feature in our TabStrip to include a new container with a new type of Tabs, the Preview Tabs. They are aligned to the right of the screen. In the moment there are one in our content a decorative purple line appears at the bottom of them.

image

This PR wants merge the current feature disabled in master. These tabs can only be enabled overriding IsPreview property in a ViewContent class and with this simple Patch: https://gist.github.com/netonjm/2d0bc8ac73ff88097dac060ec7c5388f

The objective is check we don't have any regression with the normal behaviour of the tabs, because there are some important things changed related to indexing (now we have two containers).

Testing the feature:

  • Try use shorcuts number to change the tabs
  • Try navigate the history next/previous
  • Try test accessibility keys
  • Try drop tabs into new windows, split documents etc...
  • Try resize window and discover odd behaviours in sizes
  • ....

netonjm avatar Feb 15 '18 10:02 netonjm

The value for IsPreview should not be taken from ViewContent. It is a display property of the tab, so it should be assigned directly to the tab by Document. IsPreview should be a read/write property of DockNotebookTab.

slluis avatar May 10 '18 14:05 slluis

It looks good to go, once the last couple of issues are fixed.

slluis avatar May 10 '18 15:05 slluis

Rebased on top of master

netonjm avatar May 10 '18 15:05 netonjm

I don't understand the last commit. How I can convert a normal tab to Preview and vice-versa?

slluis avatar May 30 '18 07:05 slluis

@netonjm this needs rebase from master

rodrmoya avatar Jun 18 '18 15:06 rodrmoya

@netonjm This branch needs rebase (there are several conflicts!).

jsuarezruiz avatar Jul 11 '19 08:07 jsuarezruiz

We need a "keep open" button (and icon, and keyboard shortcut), and any preview tab that becomes dirty should be automatically converted into a normal tab.

We should also verify that the preview tab is not reopened after closing and reopening the solution.

There should also only ever be one preview tab. Adding a new preview tab should replace the existing one.

What's the overflow behavior (i.e. when the tab well has too many tabs)?

mhutch avatar Jul 30 '19 17:07 mhutch