cfn-include icon indicating copy to clipboard operation
cfn-include copied to clipboard

cli --enable 'env'

Open nmccready opened this issue 5 years ago • 5 comments

Allow included documents to be pre-processed and inject env vars without needing !GetEnv

nmccready avatar Dec 18 '20 14:12 nmccready

Great idea! I'd prefer this to be more generic. Could we instead have a --enable env parameter? That way we could also enable all features individually such as --enable include,env,map etc. What do you think?

monken avatar Dec 19 '20 19:12 monken

Yeah sounds good to me .

I think we really need a follow up PR to covert all the recurse and common functions to just pass one argument of an options object . Cause the amount of arguments is getting rediculous and hard to track.

Also I think the use of bind has to go as it makes finding errors very difficult in my own experience .

nmccready avatar Dec 19 '20 22:12 nmccready

Don't merge yet, found a few bugs

nmccready avatar Dec 21 '20 18:12 nmccready

Ok should be g2g now

nmccready avatar Dec 21 '20 19:12 nmccready

anything else missing?

nmccready avatar Jan 05 '21 16:01 nmccready