biolink-api icon indicating copy to clipboard operation
biolink-api copied to clipboard

Aspect field in assoc objects

Open lpalbou opened this issue 6 years ago • 1 comments

It's great to now have the aspect field for each object of the association.

I think however it would make more sense if instead of showing the label of the aspect (more subject to change), we were showing its id ?

Example:

"object": {
  "id": "GO:0000122",
  "iri": "http://purl.obolibrary.org/obo/GO_0000122",
  "label": "negative regulation of transcription by RNA polymerase II", 
  "category": [
    "biological_process"
  ]
}

would become

"object": {
  "id": "GO:0000122",
  "iri": "http://purl.obolibrary.org/obo/GO_0000122",
  "label": "negative regulation of transcription by RNA polymerase II",
  "category": [
    "GO:0008150"
  ]
}

@deepakunni3 @cmungall

lpalbou avatar Sep 02 '19 09:09 lpalbou

As an example, it seems the label of GO:0003674 have recently changed from molecular_function to molecular_activity, presumably following the GO-CAM specs discussion ?

A query to GOLr will nonetheless shows "molecular_function" as a label whereas a query to the slimmer route will show "molecular_activity"

This is interfering with the ribbon and for the time being I will have to use a ugly patch, but this should be solved by the ticket proposal to use ID rather than label in the category field.

This either reflect that "molecular_activity" was hard coded or that we have a deeper discrepancy in our data store / fetching (e.g. out of sync between golr and ontobio loading a more up to date owl where there would have been a change from molecular_function to molecular_activity ?) @cmungall ?

lpalbou avatar Sep 03 '19 12:09 lpalbou