Roman
Roman
@richardscarrott care to contribute a benchmark case? 😜
Thanks for the tip @BasixKOR! We have benchmarks for `@marcj/marshal` (which is from the same author as Deepkit). The link to `@marcj/marshal` repo seems to redirect to Deepkit now too....
Sounds like we probably want to keep both `@marcj/marshal` and deepkit for now? @BasixKOR would you be able to contribute a PR for this?
@hoeck is the Chief Classifier in this repo, maybe he can pitch in with his thoughts? 😁
@RA80533 wanna rebase that with all of the recent changes and try again?
Seems to be the build step is failing. Is it working on your local? ``` npm run test:build ``` Does this pass?
> The import for expect-type should be removed. > > https://github.com/moltar/typescript-runtime-type-benchmarks/blob/8dc8934c57cbdd22aa85f889f4889d25ca6813e5/test/abstract.test.ts#L2 Why? It's being used for a type test.
Yeah the type tests are compile time only, as there is no way to test types at runtime.
Before your issue, I didn't have the build tests at all. It was just running jest. But I added the build step to GH Actions to catch type errors too....
> Jest already runs the TypeScript compiler through ts-jest so the extra workflow step of calling `tsc --noEmit` via `test:build` is redundant. Not redundant, because not all code is tested....