Gio Lodi

Results 138 comments of Gio Lodi

**Solved**! I run `DEBUG=* danger pr` and scrolling through the log I noticed a "Does not have TypeScript set up" message. I found the message in the transpiler source https://github.com/danger/danger-js/blob/92c2040c15947b6eb24182b46ff026a480936229/source/runner/runners/utils/transpiler.ts#L35...

I'm going to close this issue, but I wonder if Danger could do something better to let users know that they're running a `.ts` file without having TypeScript set up....

Thanks @orta and @f-meloni for the feedback. 😄 🙏 > I think the `github.api` does work though, the output of dumping it might just have getters instead of hardcoded fields...

I had [a play around](https://github.com/wordpress-mobile/WordPress-iOS/actions/runs/139305467), and it's relatively straightforward to understand whether Danger is running on a PR originated from a fork. I came up with this simple `dangerfile.ts`: ```ts...

> Also worth trying to use the Danger checks implementation on a forked PR as @stof mentioned I tried it [with this commit](https://github.com/wordpress-mobile/WordPress-iOS/pull/14345/commits/7fe74030d23f6d5d9c9bb699e085dd73655515b0), same result, see [the build here](https://github.com/wordpress-mobile/WordPress-iOS/runs/786591761#step:7:24). ```...

If the idea makes sense I'd be happy to start working on a PR for it. I've done it before and shouldn't involve too much work 👍 .

@mjarvis that would be an ideal solution, although I don't think it's possible with how SwiftLint works at the moment, at least for my understanding of it. Have you got...

Thanks for the clarification @mjarvis. I'm not familiar with this setup. Would do this ensure that building via Carthage uses the SwiftLint version fetched via CP?

Wouldn't that mean that if I tried to build the version of ReSwift fetched via Carthage which depends on the SwiftLint binary installed via CocoaPods then the build would fail...

Unless of course we were to update the [SwiftLint build phase](https://github.com/ReSwift/ReSwift/blob/9917063f6ee354a6c10de0bc7da8ed7a56e3a381/ReSwift.xcodeproj/project.pbxproj#L573) so that it only runs SwiftLint using the binary fetched by CocoaPods, if any: ```diff + swiftlint_via_cocoapods_path=... - if...