knossos

knossos copied to clipboard

This PR is to:

• [x] Fix multiple bugs
• [x] Add an in-website modpack builder
• [ ] Make project editing actually work and update to the new APIs (In progress)
• [x] Make project creation actually work and update to the new APIs
• [ ] Project version creation
• [x] Update dependencies
• [ ] Allow for better mobile accessibility
• [ ] Optimization

@RedstoneWizard08 is attempting to deploy a commit to the modrinth Team on Vercel.

A member of the Team first needs to authorize it.

@venashial What do you think about this? (It seems like you're the one spearheading the svelte port.) It still needs some work, like the version creation gives me network errors, but it mostly works. This is still WIP, but I wanted to get started on the contribution.

@venashial What do you think about this? (It seems like you're the one spearheading the svelte port.) It still needs some work, like the version creation gives me network errors, but it mostly works. This is still WIP, but I wanted to get started on the contribution.

Yes, I changed the prettier settings, but they can be reverted back to your code style once I'm done.

Hi RedstoneWizard08! Thank you for your contribution! This is a large PR, so it will take some time to look through. Keep in mind, the sveltekit-rewrite branch is still undergoing heavy development and there will be lots of merge conflicts, especially with the introduction of modrinth/omorphia.

Hi RedstoneWizard08! Thank you for your contribution! This is a large PR, so it will take some time to look through. Keep in mind, the sveltekit-rewrite branch is still undergoing heavy development and there will be lots of merge conflicts, especially with the introduction of modrinth/omorphia.

Okay, thanks! By the way, I'm also working on some other features as well, (screenshot below), and I am working on switching over to omorphia as well.

(Yes, I do most of my dev on my Chromebook lol)

After reviewing your PR, I've noticed you have made significant changes and additions to the codebase and design. Some of these changes conflict with existing and future efforts. If possible, could you wait until the rewrite is in a more stable state, and then target your changes towards that?

After reviewing your PR, I've noticed you have made significant changes and additions to the codebase and design. Some of these changes conflict with existing and future efforts. If possible, could you wait until the rewrite is in a more stable state, and then target your changes towards that?

Okay, I just wanted to try to help with the rewrite and help things along, while also adding some features. I can wait until the rewrite is done to do that, I guess.

After reviewing your PR, I've noticed you have made significant changes and additions to the codebase and design. Some of these changes conflict with existing and future efforts. If possible, could you wait until the rewrite is in a more stable state, and then target your changes towards that?

Okay, I just wanted to try to help with the rewrite and help things along, while also adding some features. I can wait until the rewrite is done to do that, I guess.

From now on, I think I'm gonna work on this as a PoC, and then once the refactor is done, I'll redo my changes (which won't be very hard), and make a new PR.

I'll leave this one open, and I'll reset it once the refactor is done. Does that sound okay, @venashial?

Sounds good, I appreciate your interest in the rewrite!

Closing -- please see my comment on #345.