mod icon indicating copy to clipboard operation
mod copied to clipboard

fix(react-ui-shadcn): fix cors issues loading images

Open stephancill opened this issue 1 year ago • 4 comments

Change Summary

Add crossOrigin="anonymous" attribute to ImageRenderer <img> elements.

Partially addresses #116 (no graceful fallback for broken images yet)

Merge Checklist

  • [x] PR has a changeset
  • [x] PR includes documentation if necessary
  • [x] PR updates the rich-embed examples if necessary
  • [x] includes a parallel PR for Mod-starter and the gateway if necessary

stephancill avatar Dec 19 '23 09:12 stephancill

🦋 Changeset detected

Latest commit: 09067ee56ccfc4a82ec35822b850093abaae7587

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@mod-protocol/react-ui-shadcn Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Dec 19 '23 09:12 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview Dec 19, 2023 9:40am
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 9:40am
example-nextjs-shadcn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 9:40am

vercel[bot] avatar Dec 19 '23 09:12 vercel[bot]

Might actually be better to implement #132 and offload the choice of how to handle CORS to the client

stephancill avatar Dec 19 '23 13:12 stephancill

fine with either or both.

davidfurlong avatar Dec 19 '23 16:12 davidfurlong