mobx.dart
mobx.dart copied to clipboard
Feat: Allow a custom equals parameter for ObservableStream
Create a custom equals parameter for ObservableStream, like what exists already for Observable.
Currently, ObservableStream uses == to determine if the value changed. This creates an option to override that with a different EqualityComparator.
https://github.com/mobxjs/mobx.dart/blob/f8677da98b2077ae22b536abe3ea11be2ba8050e/mobx/lib/src/api/async/observable_stream.dart#L439
https://github.com/mobxjs/mobx.dart/blob/f8677da98b2077ae22b536abe3ea11be2ba8050e/mobx/lib/src/core/observable.dart#L62
https://github.com/mobxjs/mobx.dart/blob/f8677da98b2077ae22b536abe3ea11be2ba8050e/mobx/lib/src/core/observable.dart#L106
https://github.com/mobxjs/mobx.dart/issues/679
Deploy Preview for mobx failed.
| Name | Link |
|---|---|
| Latest commit | e84f05e5207d8c645a366bd0943c848b43b7b472 |
| Latest deploy log | https://app.netlify.com/sites/mobx/deploys/633aa6dffe89f5000896186d |
Codecov Report
Merging #771 (e84f05e) into master (cea7013) will increase coverage by
0.00%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #771 +/- ##
=======================================
Coverage 98.90% 98.90%
=======================================
Files 55 55
Lines 1920 1923 +3
=======================================
+ Hits 1899 1902 +3
Misses 21 21
| Flag | Coverage Δ | |
|---|---|---|
| flutter_mobx | 100.00% <ø> (ø) |
|
| mobx | 98.45% <100.00%> (+<0.01%) |
:arrow_up: |
| mobx_codegen | 100.00% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| mobx/lib/src/api/async/observable_future.dart | 100.00% <100.00%> (ø) |
|
| mobx/lib/src/api/async/observable_stream.dart | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update cea7013...e84f05e. Read the comment docs.
Can you resolve conflicts pls before the merge. Also will need to bump up the version for publishing and add to changelog
@pavanpodila Done.
@all-contributors please add @amondnet for doc