assembly

assembly copied to clipboard

I've added compiler test suite to Assembly to see how it goes.

So far, it goes pretty well. There is only one catch about how to handle exceptions regarding parameters passed. I might remove this test, but it probably means we should discuss about what is ok and what is not as a parameter.

For instance: is it ok to pass an object as a parameter? etc...

Failing test is here: https://github.com/container-interop/definition-interop-compiler-test-suite/blob/master/src/AbstractDefinitionCompatibilityTest.php#L49-L57

Also, I've had to add the "version" to composer.json. I don't like it, but since container-interop/definition-interop-compiler-test-suite require assembly, there is a cyclic dependency that can only be solved by specifying the version number of the root package to composer. An alternative would be to split Assembly in 2 packages: the classes implementing definition-interop interface and the compiler. But that's getting a bit out of scope.

Thank you that's something I wanted to do but didn't have time yet. Ideally the test suite shouldn't depend on Assembly, but I haven't looked at it so I have no idea if it's easy to do. That would solve the dependency issue though.