so-simple-theme icon indicating copy to clipboard operation
so-simple-theme copied to clipboard

Add body-custom include to facilitate loading custom elements at the body start

Open eddgrant opened this issue 4 years ago • 6 comments
trafficstars

This is a bug fix.

Summary

Hi, I am in the process of setting up Google Tag Manager and am using the t-richards/jekyll-google-tag-manager plugin. GTM seems to require code to be inserted as the first thing in the <body> element in order to function. To support this I have introduced a body-custom.html include. I thought this have other, more general, use cases so wanted to offer it back in case you are keen to include it. Having it included upstream also benefits me of course as I no longer have to maintain a custom default.html :grin: .

Let me know what you think, but regardless of your decision thank you for all your work on the theme, it's really excellent :pray:

Edd

eddgrant avatar Jan 18 '21 17:01 eddgrant

This pull request has been automatically marked as stale because it has not had recent activity.

This pull request will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.

github-actions[bot] avatar May 14 '21 02:05 github-actions[bot]

As a user, I also consider this a very useful feature and would love seeing this merged. The stale-bot sadly encourages bumping PRs to keep them open, and there seem to be no maintainers of the project around :cry: .

olifre avatar May 14 '21 07:05 olifre

This pull request has been automatically marked as stale because it has not had recent activity.

This pull request will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.

github-actions[bot] avatar Jul 15 '21 02:07 github-actions[bot]

The dreaded stale-bot passed by again — it sadly encourages bumping PRs to keep them open, and there seem to be no maintainers of the project around :cry:.

olifre avatar Jul 15 '21 02:07 olifre

This pull request has been automatically marked as stale because it has not had recent activity.

This pull request will automatically be closed in 7 days if no further activity occurs. Thank you for all your contributions.

github-actions[bot] avatar Sep 15 '21 02:09 github-actions[bot]

The dreaded stale-bot passed by again — it sadly encourages bumping PRs to keep them open, and there seem to be no maintainers of the project around :cry:.

olifre avatar Sep 15 '21 23:09 olifre