ParamHelpers

ParamHelpers copied to clipboard

Fixes for: #180 #181 #182

Coverage decreased (-0.03%) to 96.03% when pulling 8096d7176e7dbff3d7e074716d5bb7fa3c10fd43 on mb706:mb706_fixes into e233aa7c9ec031ab9c1bfa91e47afefeda23bfa5 on berndbischl:master.

Coverage decreased (-0.03%) to 96.03% when pulling b98b9277192741e2f4ef4b4c46f44ab902adc0bc on mb706:mb706_fixes into e233aa7c9ec031ab9c1bfa91e47afefeda23bfa5 on berndbischl:master.

My comment still stands

Coverage decreased (-0.03%) to 96.03% when pulling c19ca1fd08b7cf3a16431e11ceb9fa23514bdb1e on mb706:mb706_fixes into e233aa7c9ec031ab9c1bfa91e47afefeda23bfa5 on berndbischl:master.

Coverage increased (+0.2%) to 96.268% when pulling a3d2c6a291cc51c040413f2077f585d9a4dda85a on mb706:mb706_fixes into e233aa7c9ec031ab9c1bfa91e47afefeda23bfa5 on berndbischl:master.

Because this thread is invisible let's continue it here:

@mb706 wrote: You're right, I didn't consider the other points from which discreteValueToName gets called. I'd still say the printout of a discreteVectorLearnerParam with default list() shouldn't have character(0) in it.

I agree in this point. You mentioned it here but the conversion to character(0) is already here (discreteValueToName). But it could also be fixed in paramValueToString.Param.

> makeDiscreteVectorLearnerParam("x", NA, values=c("a", "b", "c"), default = list())
            Type len    Def Constr Req Tunable Trafo
1 discretevector  NA list()  a,b,c   -    TRUE     -
Used: train.

looks nice.