mlflow icon indicating copy to clipboard operation
mlflow copied to clipboard

[BUG] UI breaks if project name contains a "/"

Open captify-eraffenne opened this issue 5 years ago • 1 comments

Thank you for submitting an issue. Please refer to our issue policy for additional information about bug reports. For help with debugging your code, please refer to Stack Overflow.

Please fill in this bug report template to ensure a timely and thorough response.

Willingness to contribute

The MLflow Community encourages bug fix contributions. Would you or another member of your organization be willing to contribute a fix for this bug to the MLflow code base?

  • [ ] Yes. I can contribute a fix for this bug independently.
  • [ ] Yes. I would be willing to contribute a fix for this bug with guidance from the MLflow community.
  • [x] No. I cannot contribute a bug fix at this time.

System information

  • Have I written custom code (as opposed to using a stock example script provided in MLflow): no
  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04): MacOS 10.15.7
  • MLflow installed from (source or binary): binary (pip)
  • MLflow version (run mlflow --version): 1.12.1
  • Python version: 3.7.7
  • npm version, if running the dev UI:
  • Exact command to reproduce: Register a model from a run including a "/" in the model name

Describe the problem

If a model name contains a "/", e.g. "my-namespace/my-model", then it is interpreted as a path when building the URL to that model and clicking on it will return a 404 error.

Code to reproduce issue

No code necessary. UI issue.

Other info / logs

Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

What component(s), interfaces, languages, and integrations does this bug affect?

Components

  • [ ] area/artifacts: Artifact stores and artifact logging
  • [ ] area/build: Build and test infrastructure for MLflow
  • [ ] area/docs: MLflow documentation pages
  • [ ] area/examples: Example code
  • [x] area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • [ ] area/models: MLmodel format, model serialization/deserialization, flavors
  • [ ] area/projects: MLproject format, project running backends
  • [ ] area/scoring: Local serving, model deployment tools, spark UDFs
  • [ ] area/server-infra: MLflow server, JavaScript dev server
  • [ ] area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • [x] area/uiux: Front-end, user experience, JavaScript, plotting
  • [ ] area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • [ ] area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • [ ] area/windows: Windows support

Language

  • [ ] language/r: R APIs and clients
  • [ ] language/java: Java APIs and clients
  • [ ] language/new: Proposals for new client languages

Integrations

  • [ ] integrations/azure: Azure and Azure ML integrations
  • [ ] integrations/sagemaker: SageMaker integrations
  • [ ] integrations/databricks: Databricks integrations

captify-eraffenne avatar Nov 26 '20 10:11 captify-eraffenne

@captify-eraffenne Recently, I started exploring mlflow with regards to my internal company project and I'm willing to contribute this feature with guidance from the MLflow community.

hegdeashwin avatar May 01 '21 12:05 hegdeashwin

Hi @dbczumar , I'm happy to take on this issue if it's still not assigned, please let me know!

jaeday avatar Nov 09 '22 05:11 jaeday

Hi jaeday, thank you for picking up this issue! Looking forward to your contribution!

dbczumar avatar Nov 09 '22 05:11 dbczumar

Hi @dbczumar , we tried to replicate this bug but it does seem like the bug is fixed, the UI does not break if the project name contains a slash.

Here's a screen recording of us trying to replicate the bug: https://drive.google.com/file/d/1CPAtbaiwWU8YHDvS-UbF4-2HkroJ8OWp/view?usp=sharing

Let me know if I missed anything in trying to replicate this bug, and if the bug looks fixed from your end as well, how to move on with this issue!

jaeday avatar Dec 07 '22 15:12 jaeday

Hi @dbczumar I'm able to replicate this bug and would be happy to work on this if you would like to assign the issue to me, cheers!

ericvincent18 avatar May 11 '23 01:05 ericvincent18