ssh-proxy icon indicating copy to clipboard operation
ssh-proxy copied to clipboard

Add missing env variables to start_ssh.py

Open hSATAC opened this issue 5 years ago • 0 comments

We need to pass these variables to update_authorized_keys.py

  1. SSH_TARGET_PUBLICKEY_API_PORT to override the API port
  2. Kubernetes info so the config.load_incluster_config() can work

References:

  • https://github.com/kubernetes-client/python-base/blob/54d188f89e462e4c829aa9acb44d5c09cc5030ae/config/incluster_config.py#L22-L25
  • https://github.com/ml-tooling/ssh-proxy/blob/master/docker-res/ssh/update_authorized_keys.py#L23

Signed-off-by: Ash Wu [email protected] Signed-off-by: Timothy Lee [email protected]

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] New Feature
  • [x] Feature Improvment
  • [ ] Refactoring
  • [ ] Documentation
  • [ ] Other, please describe:

Description:

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [x] My changes don't require a change to the documentation, or if they do, I've added all required information.

hSATAC avatar Aug 04 '20 09:08 hSATAC