Hitoshi Mitake
Hitoshi Mitake
I could reproduce the bug on the latest main branch... Let me reopen the issue and handle it.
This is the branch for the fix: https://github.com/mitake/etcd/tree/watch-auth-err I'll open a PR after finalizing it.
Thanks for commenting @kafuu-chino , actually I think `Create new watch stream when the token expired.` is a better way.
@jwebb @sayap @kafuu-chino I opened this PR: https://github.com/etcd-io/etcd/pull/14322 I checked the above test case can pass now. Could you cross check if you have time?
@kafuu-chino I'll also check your PR https://github.com/etcd-io/etcd/pull/14296 later, thanks for opening this!
@ptabor Thanks for figuring out this. I'll try to reproduce and analyze related code this weekend.
@ptabor I'm still trying to reproduce, but invalidating `rangePermCache` in `authStore.Recover()` is fine and good for defensive purpose. I'll open a PR for the change.
@kafuu-chino Could you squash the 2 commits into one, and change the commit title like this? `*: avoid closing a watch with ID 0 incorrectly` ~I think the test failure...
@kafuu-chino I'm writing a test case in https://github.com/etcd-io/etcd/pull/14322/commits/ff9c6612f7dff2dd730ee4be0c4ab167ba042e6f for https://github.com/etcd-io/etcd/pull/14322 For now the test case is still in progress (for some reasons the unary interceptor refreshes the token so the...
@kafuu-chino @ahrtr I finalized the test for my PR in https://github.com/etcd-io/etcd/pull/14322/commits/94fd1612949e5b4279e923efdec7b2de67e5d3bc I think it can be extended for covering the change in this PR. Let me think about it. Probably...