Peter Johnson

Results 884 comments of Peter Johnson

Hi @NickStallman the tests are still failing, you can run the same tests locally that are getting run on CI with `npm run travis`, you can also view the logs...

This is looking really good, I opened a small PR against your fork with some minor formatting changes. Other than that, I think we should merge this.

All good, I will hold off merging until I hear more.

This was motivated by the following results from a TV series showing up for the query `90210`:

I also considered implementing something similar in `pelias/schema` where we would store the original text verbatim but only *index* the tokens outside the parenthesis. It's also not without its potential...

Good catch, this is not required.

You can mix datasets but the only issue will be deduplication. If you have duplicate streets, but with different paths, then it's possible that some addresses are associated with one...

Oh sorry, I thought this issue was for `pelias/interpolation`, so the above is relevant to that repo. For `pelias/polylines` I believe there is something which hard-codes the `source` to openstreetmap,...

Deduplication will also be an issue, although `pelias/api` will make some attempts to deduplicate results before they are returned to the user.

Hmm you are correct, we did not have need to import multiple polylines files until now. Two options: - (easy way) join the files in to one file - (hard...