Peter Johnson
Peter Johnson
I rebased this and put it up on dev today, it fixes the "vanity addresses" issue we've been discussing: cc/ @blackmad
linked https://github.com/pelias/acceptance-tests/pull/533
I ran the full acceptance test suite on this today and there were actually quite a few improvements, but at the same time it highlighted some issues. diff of changes...
Right, so the question is "which parser does a better job of venues?" and the answer is "no" 😆
Please check all the software is up-to-date, the code which handles street suffix contraction/expansion has been around for some years now. There is also some other code specific to these...
Hi @mihneadb, unfortunately, it's me whos the blocker here, I would like to land https://github.com/pelias/api/pull/1287 before merging this (It's a complex change but I'm planning on doing the final testing...
Oh actually I thought this was another PR, but the same still applies to this one ;)
I've been sick this week but releasing the new parser is a top priority.
Paired with https://github.com/pelias/parser/pull/120 these tests all pass 🎉
added an additional commit https://github.com/pelias/api/pull/1487/commits/ac26263bb21fd653e0af7504aaaf0cb5563d22a2 to improve parsing of addresses where the unit number was previously being included in the $admin section of the parse: