terraform-github-team icon indicating copy to clipboard operation
terraform-github-team copied to clipboard

feat: Use `github_team_members` for authoritative members management

Open RafPe opened this issue 3 years ago • 5 comments

Hey there!

First of all great module 💪 While using it I noticed there is the possibility to use github_team_members to manage team membership so terraform becomes ultimately authoritative for the resource.

I would be happy to make a PR if u would be open to such change.

RafPe avatar Aug 24 '22 08:08 RafPe

Hi @RafPe ,

Thanks for your suggestion! Let me talk to the team tomorrow and come back to you :) Also, thanks for offering to contribute through PRs - we encourage you to do that!

Thanks!

soerenmartius avatar Aug 24 '22 21:08 soerenmartius

@soerenmartius any update ? Are you guys open for that kind of change ?

RafPe avatar Sep 07 '22 08:09 RafPe

Hello there,

Great suggestion @RafPe ⭐

Using github_team_members should considerably decrease the use of the GitHub API, so this is almost required to go that way when running larger organisations.

How have the thoughts been @soerenmartius and @mariux regarding this?

Kind regards, Tobias

tobiasehlert avatar Apr 26 '23 04:04 tobiasehlert

Created PR #65 to add this feature :)

tobiasehlert avatar Apr 27 '23 13:04 tobiasehlert

@soerenmartius any updates on the possible merge ?

RafPe avatar Nov 15 '23 14:11 RafPe