terraform-aws-s3-bucket icon indicating copy to clipboard operation
terraform-aws-s3-bucket copied to clipboard

Published 20 hours ago • verified publisher icon mineiros-io

implement ACL policy grants

Open treksler opened this issue 3 years ago • 4 comments

treksler avatar Jun 02 '22 20:06 treksler

thank you for your contribution.. the team will look into it asap.. ;) looks very good on first sight 👍

mariux avatar Jun 03 '22 08:06 mariux

A few missing things:

  • Document the new variable grants
  • Add the new variable to the unit tests
  • Make sure README.md is generated from README.tfdoc.hcl using terradoc.

zied-elouaer avatar Jul 08 '22 10:07 zied-elouaer

i gave it a shot to address the missing things

  • wasn't really sure what to add to the unit tests. I just added a grants block to one of the examples
  • hopefully the documentation changes are what you require

treksler avatar Oct 06 '22 16:10 treksler

the only errors in https://github.com/mineiros-io/terraform-aws-s3-bucket/actions/runs/3198717372/jobs/5336038710 seem to be around "dead" links, which aren't actually dead

treksler avatar Oct 28 '22 00:10 treksler