terraform-aws-s3-bucket

terraform-aws-s3-bucket copied to clipboard

I split this commit to make my changes easier to check. Please have a look at https://github.com/mineiros-io/terraform-aws-s3-bucket/commit/8fe3fe3b91b414548760697543bdd8540fddd834 and let me know if anything need to be done to merge this in master.

Thanks for this awesome module.

Hi @aminehmida,

thanks for your great contribution. I will discuss needed changes to your PR with the team and add comments within the next days.

We do have some internal guidelines to keep base modules within one service and not add other services like roles into them.. but it makes totally sense to create the replication role with the replication configuration tbh.

so far:

I split this commit to make my changes easier to check. Please have a look at 8fe3fe3 and let me know if anything need to be done to merge this in master.

no need to split commits here, as you can disable whitespace changes in the review console of github.. - check it out now ;) could you squash the two commits and force push again? not a hard requirement though ;)

Thanks again :rocket:

Hey, anything blocking this from being merged? We'd love to see these changes in master.

Hey, anything blocking this from being merged? We'd love to see these changes in master.

Hi @Limess ,

Let me discuss this with the team. This PR needs some changes in order to be merged back to master but we might be able to handle this internally this week.

This is very old. I am not working on this anymore. Feel free to use my code and make another PR if you like. Just going to close it for now.