doctr icon indicating copy to clipboard operation
doctr copied to clipboard

fix: Trying to fix API template

Open frgfm opened this issue 3 years ago • 6 comments

Following up on #847, this PR introduces the following changes:

  • updates version pin for fastAPI & uvicorn to debug API template

Any feedback is welcome!

frgfm avatar May 18 '22 13:05 frgfm

Mmmh it looks like there are several dependency issues 🤔

frgfm avatar May 18 '22 13:05 frgfm

Codecov Report

Merging #922 (c4c6aac) into main (d802630) will increase coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #922      +/-   ##
==========================================
+ Coverage   94.72%   94.74%   +0.01%     
==========================================
  Files         134      134              
  Lines        5479     5479              
==========================================
+ Hits         5190     5191       +1     
+ Misses        289      288       -1     
Flag Coverage Δ
unittests 94.74% <ø> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
doctr/transforms/functional/base.py 97.10% <0.00%> (+1.44%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d802630...c4c6aac. Read the comment docs.

codecov[bot] avatar May 18 '22 13:05 codecov[bot]

@frgfm maybe useful to add dependabot action ? :)

felixdittrich92 avatar May 18 '22 14:05 felixdittrich92

@felixdittrich92 to the best of my knowledge, the dependabot is helpful to make you keep this up to date, but it doesn't take breaking changes into account 🤔 So I doubt it would work

frgfm avatar May 22 '22 20:05 frgfm

@frgfm mh yes .. btw pinning httptools to 0.1.2 solves the dependency conflict and i think if we run compose as root could solve the docs issue

felixdittrich92 avatar May 23 '22 14:05 felixdittrich92

@frgfm mh yes .. btw pinning httptools to 0.1.2 solves the dependency conflict and i think if we run compose as root could solve the docs issue

I cannot run the docker correctly with my current setup, but once I get my hands on my new one, I'll be able to get back into docker and fix this 👍 (within a few weeks max)

frgfm avatar May 25 '22 19:05 frgfm

Hi @frgfm :wave: do you think we can close this ? .)

felixdittrich92 avatar Aug 24 '22 07:08 felixdittrich92

Sure!

frgfm avatar Aug 27 '22 09:08 frgfm